Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SW-May2015 - updating IBrokers to IB clientVersion63 #9

Closed
wants to merge 1 commit into from
Closed

SW-May2015 - updating IBrokers to IB clientVersion63 #9

wants to merge 1 commit into from

Conversation

censix
Copy link

@censix censix commented May 2, 2015

Hi Joshua

I worked on incorporating my changes into the IBrokers package source code. The package builds ok with "R CMD build ...", but I have no time to do extensive (unit) testing at the moment. Please review the changes and modify as you see fit.

regards

Soren

@joshuaulrich
Copy link
Owner

Thanks for the patch, but it's very hard to review the functional changes with all the changes to formatting, comments, and whitespace.

Even ignoring whitespace changes, there are still a lot of comments removed, wrapped lines added, braces on same/new lines, etc. It will take me a long time to carefully review all the changes to look for the meaningful changes you made.

@censix
Copy link
Author

censix commented May 2, 2015

Jashua, it is your decision if you want to incorporate these changes into
the official IBrokers package of course. I am just making them available
to you as the package maintainer. Unfortunately I do not have the time to
give each function the 'look and feel' you would like to see. That is
cosmetics .... unless you or others would like to sponsor that time. Best
regards.

On Sat, May 2, 2015 at 4:29 PM, Joshua Ulrich [email protected]
wrote:

Thanks for the patch, but it's very hard to review the functional changes
with all the changes to formatting, comments, and whitespace.

Even ignoring whitespace changes
https://github.com/joshuaulrich/IBrokers/pull/9/files?w=1, there are
still a lot of comments removed, wrapped lines added, braces on same/new
lines, etc. It will take me a long time to carefully review all the changes
to look for the meaningful changes you made.

—
Reply to this email directly or view it on GitHub
#9 (comment).

@joshuaulrich
Copy link
Owner

My comment has nothing to do with cosmetics. My point is that I cannot review your changes without spending a substantial amount of my time manually searching for the changes you made that would actually affect functionality.

@kalka0
Copy link

kalka0 commented Mar 4, 2016

Hello Joshua. I am an happy user of IBrokers. A very valuable tool. Unfortunately the package has become unreliable since the IB changes mentioned in this post. twsConnect assigns random clientIds, and often $clientId provides a wrong code (i.e. the clientId assigned by IB is different from what is seems). I would love to contribute somehow to fix this but unfortunately IBrokers is well beyond my skills. I am wondering if you plan some fix anytime soon... Thanks

@ghost
Copy link

ghost commented Jan 31, 2018

#14

joshuaulrich added a commit that referenced this pull request Sep 19, 2019
@joshuaulrich
Add startApi() to create the API connection
77f4b04 
The handshake between the server and client changed somewhere between
version 47 and 63. Now it needs a START_API message after the client
and server versions have been established.

The server responds to the START_API message with
  1. a managed account message,
  2. a next valid ID, and
  3. messages with the status of the data farms

Soren did not store the server response, so this commit does not
recreate his PR verbatim. One major difference: this change does not
remove the ewrapper, so the next valid ID is still stored in the
ewrapper environment instead of the global environment (as it does in
Soren's PR).

See #19, see #9.
joshuaulrich added a commit that referenced this pull request Sep 19, 2019
@joshuaulrich
Add changes missed when updating to v63
19695d6 
I attempted to merge all the functional changes from Soren Wilkening's
pull request (#9) in a9ae056.

I missed a lot. This commit attempts to restore the functional changes
I missed. It also adds a few of Soren's comments, including some
blocks of commented code.

See #19.
@vspinu
Copy link
Contributor

vspinu commented Jun 23, 2022

Heads up about rib which is a wrapper around official tws-api client. Thus aims to be 100% feature complete and easy to maintain.

@joshuaulrich joshuaulrich mentioned this pull request Sep 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@censix @joshuaulrich @kalka0 @vspinu